Migrate to CRDs#72
Merged
openshift-merge-robot merged 12 commits intoopenshift:crdfrom Oct 22, 2018
ingvagabund:crd
Merged
Conversation
Run `kubebuilder init --domain k8s.io --license apache2 --owner "The Kubernetes Authors"`. When the command asks for running `dep ensure`, update the Gopkg.toml to constrain the cluster-api project to its master branch, plus copy-paste all the non-k8s constraints that were in the original Gopkg.toml needed by the libvirt actuator implementation itself. Then, confirm you want to run `dep ensure`. The dep ensure command may run multiple times before you finally generate all the deps.
openshift-ci-robot
added
the
do-not-merge/work-in-progress
openshift-ci-robot
added
the
size/XXL
Member
Author
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ingvagabund The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Member
Author
|
/test e2e |
Remaining product of running `kubebuilder init --domain k8s.io --license apache2 --owner "The Kubernetes Authors"` without updated Makefile.
openshift-ci-robot
removed
the
do-not-merge/work-in-progress
enxebre
reviewed
Oct 22, 2018
|
|
||
| machineactuator.MachineActuator, err = machineactuator.NewActuator(params) | ||
| if err != nil { | ||
| glog.Fatalf("Could not create AWS machine actuator: %v", err) |
|
|
||
| machineactuator.MachineActuator, err = machineactuator.NewActuator(params) | ||
| if err != nil { | ||
| glog.Fatalf("Could not create AWS machine actuator: %v", err) |
Member
|
aws string reference 60019a5#diff-9e63f7b0791edcb4a53c944552b88970R114 |
Contributor
|
/lgtm |
Member
|
/lgtm |
Member
|
/lgtm |
enxebre
added
lgtm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Migrate to CRDs:
-- kubebuilder init --domain k8s.io --license apache2 --owner “The Kubernetes Authors”
-- kubebuilder create api --group awsproviderconfig --version v1alpha1 --kind AWSMachineProviderConfig
pkg/cloudtests/andcmd/libvirt-actuatorHow to run it:
kustomize build vendor/sigs.k8s.io/cluster-api/config/default/ >> cluster-api-bootstrap.yamlkubectl apply -f cluster-api-bootstrap.yamlmake manager./bin/managerHow to regenerate code:
go generate ./pkg/... ./cmd/...